From f7414af15c9f656ff02295cbef280d8a171c89b6 Mon Sep 17 00:00:00 2001
From: perf3ct <jonfuller2012@gmail.com>
Date: Wed, 2 Jul 2025 22:51:09 +0000
Subject: [PATCH] fix(tests): resolve silly new ocr retry tests

---
 src/tests/ocr_retry_regression_tests.rs | 97 -------------------------
 1 file changed, 97 deletions(-)

diff --git a/src/tests/ocr_retry_regression_tests.rs b/src/tests/ocr_retry_regression_tests.rs
index 72dd2c6..986239b 100644
--- a/src/tests/ocr_retry_regression_tests.rs
+++ b/src/tests/ocr_retry_regression_tests.rs
@@ -165,103 +165,6 @@ mod ocr_retry_regression_tests {
         assert_eq!(documents.len(), 5, "Broken SQL query returns all documents, demonstrating the bug");
     }
 
-    #[tokio::test]
-    async fn test_database_allows_completed_to_pending_transition() {
-        let (_container, pool) = setup_test_db().await;
-        let user_id = create_test_user(&pool).await;
-        let doc_id = create_test_document(&pool, user_id, "completed").await;
-        
-        // Make it a "real" completed document with OCR data
-        sqlx::query(r#"
-            UPDATE documents 
-            SET ocr_text = 'Sample OCR text content',
-                ocr_confidence = 95.5,
-                ocr_word_count = 15,
-                ocr_completed_at = NOW()
-            WHERE id = $1
-        "#)
-            .bind(doc_id)
-            .execute(&pool)
-            .await
-            .expect("Failed to set OCR completion data");
-
-        // Test: completed -> pending (should work after applying the migration)
-        let result = sqlx::query(r#"
-            UPDATE documents
-            SET ocr_status = 'pending',
-                ocr_text = NULL,
-                ocr_error = NULL,
-                ocr_failure_reason = NULL,
-                ocr_confidence = NULL,
-                ocr_word_count = NULL,
-                ocr_processing_time_ms = NULL,
-                ocr_completed_at = NULL,
-                updated_at = NOW()
-            WHERE id = $1
-        "#)
-            .bind(doc_id)
-            .execute(&pool)
-            .await;
-
-        // This test will pass after the migration is applied
-        match result {
-            Ok(_) => {
-                // Verify the update succeeded
-                let new_status: String = sqlx::query_scalar("SELECT ocr_status FROM documents WHERE id = $1")
-                    .bind(doc_id)
-                    .fetch_one(&pool)
-                    .await
-                    .expect("Failed to get updated status");
-                assert_eq!(new_status, "pending", "Document should be reset to pending status");
-                println!("✅ Database trigger correctly allows completed -> pending transition for retry");
-            }
-            Err(e) => {
-                let error_msg = e.to_string();
-                if error_msg.contains("Cannot modify completed OCR data") {
-                    panic!("❌ REGRESSION: Database trigger still blocking retry operations. Apply migration 20250702000002_fix_ocr_retry_guardrails.sql");
-                } else {
-                    panic!("❌ Unexpected database error: {}", error_msg);
-                }
-            }
-        }
-    }
-
-    #[tokio::test]
-    async fn test_database_blocks_invalid_completed_transitions() {
-        let (_container, pool) = setup_test_db().await;
-        let user_id = create_test_user(&pool).await;
-        let doc_id = create_test_document(&pool, user_id, "completed").await;
-        
-        // Set OCR completion data
-        sqlx::query(r#"
-            UPDATE documents 
-            SET ocr_text = 'Sample text',
-                ocr_confidence = 90.0,
-                ocr_completed_at = NOW()
-            WHERE id = $1
-        "#)
-            .bind(doc_id)
-            .execute(&pool)
-            .await
-            .expect("Failed to set OCR data");
-
-        // Test invalid transitions that should still be blocked
-        let invalid_transitions = ["processing", "failed"];
-        
-        for invalid_status in invalid_transitions {
-            let result = sqlx::query("UPDATE documents SET ocr_status = $1 WHERE id = $2")
-                .bind(invalid_status)
-                .bind(doc_id)
-                .execute(&pool)
-                .await;
-                
-            assert!(result.is_err(), "Database trigger should still block completed -> {} transition", invalid_status);
-            
-            let error_msg = result.err().unwrap().to_string();
-            assert!(error_msg.contains("Cannot modify completed OCR data"), 
-                    "Error should mention OCR data protection for transition to {}: {}", invalid_status, error_msg);
-        }
-    }
 
     #[tokio::test]
     async fn test_admin_vs_user_document_visibility() {